Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3c7984e9 authored by Janusz Dziedzic's avatar Janusz Dziedzic Committed by Kalle Valo
Browse files

ath10k: don't create bssid peer for ibss 



It's not really necessary to create bssid peer for
bssid. Self-address peer is sufficient.

This prevents some firmware revisions from crashing.

Signed-off-by: default avatarJanusz Dziedzic <janusz.dziedzic@tieto.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 2358a544

drivers/net/wireless/ath/ath10k/mac.c

+10 −18
Original line number Diff line number Diff line
@@ -992,14 +992,6 @@ static void ath10k_control_ibss(struct ath10k_vif *arvif, 
		if (is_zero_ether_addr(arvif->bssid))

			return;



		ret = ath10k_peer_delete(arvif->ar, arvif->vdev_id,

					 arvif->bssid);

		if (ret) {

			ath10k_warn(ar, "failed to delete IBSS BSSID peer %pM for vdev %d: %d\n",

				    arvif->bssid, arvif->vdev_id, ret);

			return;

		}



		memset(arvif->bssid, 0, ETH_ALEN);



		return;
@@ -3127,6 +3119,7 @@ static void ath10k_bss_info_changed(struct ieee80211_hw *hw, 
	if (changed & BSS_CHANGED_BSSID &&

	    vif->type != NL80211_IFTYPE_AP) {

		if (!is_zero_ether_addr(info->bssid)) {

			if (vif->type == NL80211_IFTYPE_STATION) {

				ath10k_dbg(ar, ATH10K_DBG_MAC,

					   "mac vdev %d create peer %pM\n",

					   arvif->vdev_id, info->bssid);
@@ -3135,9 +3128,8 @@ static void ath10k_bss_info_changed(struct ieee80211_hw *hw, 
							 info->bssid);

				if (ret)

					ath10k_warn(ar, "failed to add peer %pM for vdev %d when changing bssid: %i\n",

					    info->bssid, arvif->vdev_id, ret);



			if (vif->type == NL80211_IFTYPE_STATION) {

						    info->bssid, arvif->vdev_id,

						    ret);

				/*

				 * this is never erased as we it for crypto key

				 * clearing; this is FW requirement