Commit 3c2f9ef9 authored Jun 01, 2020 by Vasily Averin Committed by Sasha Levin Jun 30, 2020

sunrpc: fixed rollback in rpc_gssd_dummy_populate()



commit b7ade38165ca0001c5a3bd5314a314abbbfbb1b7 upstream.

__rpc_depopulate(gssd_dentry) was lost on error path

cc: stable@vger.kernel.org
Fixes: commit 4b9a445e ("sunrpc: create a new dummy pipe for gssd to hold open")
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 3fe2a013

net/sunrpc/rpc_pipe.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1331,6 +1331,7 @@ rpc_gssd_dummy_populate(struct dentry root, struct rpc_pipe pipe_data)
		q.len = strlen(gssd_dummy_clnt_dir[0].name);
		clnt_dentry = d_hash_and_lookup(gssd_dentry, &q);
		if (!clnt_dentry) {
		__rpc_depopulate(gssd_dentry, gssd_dummy_clnt_dir, 0, 1);
		pipe_dentry = ERR_PTR(-ENOENT);
		goto out;
		}