Commit 3bded569 authored Jul 09, 2017 by Marek Vasut Committed by Stephen Boyd Jul 17, 2017

clk: vc5: Prevent division by zero on unconfigured outputs



In case the initial values of the FOD registers are not configured in
the OTP or by the bootloader, it is possible that the FOD registers
will contain zeroes. The code in vc5_fod_recalc_rate() immediately
feeds the FOD divider value obtained from the FOD registers into the
div64_u64() and if the FOD divider value is zero, triggers division
by zero exception.

Check if the FOD divider value is zero and return the frequency of
the FOD output as 0 Hz if it is so. This prevents the division by
zero exception.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Alexey Firago <alexey_firago@mentor.com>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org
Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> # Salvator-XS with the display LVDS output.
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

parent 6d7489c7

drivers/clk/clk-versaclock5.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -426,6 +426,10 @@ static unsigned long vc5_fod_recalc_rate(struct clk_hw *hw,
		div_frc = (od_frc[0] << 22) \| (od_frc[1] << 14) \|
		(od_frc[2] << 6) \| (od_frc[3] >> 2);

		/* Avoid division by zero if the output is not configured. */
		if (div_int == 0 && div_frc == 0)
		return 0;

		/* The PLL divider has 12 integer bits and 30 fractional bits */
		return div64_u64((u64)f_in << 24ULL, ((u64)div_int << 24ULL) + div_frc);
		}