dmaengine: edma: Re-evaluate errors when ccerr is triggered w/o error event (3b2bc8a7) · Commits · e / devices / android_kernel_fairphone_FP4

When the ccerr handler is called but the error registers indicate no error events we need to command eDMA to re-evaluate the errors. Otherwise we can receive flood of error interrupts. Reported-by:

Roger Quadros <rogerq@ti.com> Signed-off-by:

Peter Ujfalusi <peter.ujfalusi@ti.com> Signed-off-by:

Vinod Koul <vinod.koul@intel.com>

drivers/dma/edma.c

+10 −1

Original line number	Diff line number	Diff line
		@@ -1518,8 +1518,17 @@ static irqreturn_t dma_ccerr_handler(int irq, void *data)

		dev_vdbg(ecc->dev, "dma_ccerr_handler\n");

		if (!edma_error_pending(ecc))
		if (!edma_error_pending(ecc)) {
		/*
		* The registers indicate no pending error event but the irq
		* handler has been called.
		* Ask eDMA to re-evaluate the error registers.
		*/
		dev_err(ecc->dev, "%s: Error interrupt without error event!\n",
		__func__);
		edma_write(ecc, EDMA_EEVAL, 1);
		return IRQ_NONE;
		}

		while (1) {
		/* Event missed register(s) */