Commit 3b1cac4d authored Aug 23, 2015 by Julia Lawall Committed by Ulf Hansson Aug 27, 2015

mmc: usdhi6rol0: fix error return code

Propagate error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent 38276a91

drivers/mmc/host/usdhi6rol0.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1737,8 +1737,10 @@ static int usdhi6_probe(struct platform_device *pdev)
		}

		host->clk = devm_clk_get(dev, NULL);
		if (IS_ERR(host->clk))
		if (IS_ERR(host->clk)) {
		ret = PTR_ERR(host->clk);
		goto e_free_mmc;
		}

		host->imclk = clk_get_rate(host->clk);