Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3b05ac38 authored by Dan Carpenter's avatar Dan Carpenter Committed by Simon Horman
Browse files

ipvs: uninitialized data with IP_VS_IPV6 



The app_tcp_pkt_out() function expects "*diff" to be set and ends up
using uninitialized data if CONFIG_IP_VS_IPV6 is turned on.

The same issue is there in app_tcp_pkt_in().  Thanks to Julian Anastasov
for noticing that.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarJulian Anastasov <ja@ssi.bg>
Signed-off-by: default avatarSimon Horman <horms@verge.net.au>
parent d6b00fec

net/netfilter/ipvs/ip_vs_ftp.c

+5 −5
Original line number Diff line number Diff line
@@ -183,6 +183,8 @@ static int ip_vs_ftp_out(struct ip_vs_app *app, struct ip_vs_conn *cp, 
	struct nf_conn *ct;

	struct net *net;



	*diff = 0;



#ifdef CONFIG_IP_VS_IPV6

	/* This application helper doesn't work with IPv6 yet,

	 * so turn this into a no-op for IPv6 packets
@@ -191,8 +193,6 @@ static int ip_vs_ftp_out(struct ip_vs_app *app, struct ip_vs_conn *cp, 
		return 1;

#endif



	*diff = 0;



	/* Only useful for established sessions */

	if (cp->state != IP_VS_TCP_S_ESTABLISHED)

		return 1;
@@ -322,6 +322,9 @@ static int ip_vs_ftp_in(struct ip_vs_app *app, struct ip_vs_conn *cp, 
	struct ip_vs_conn *n_cp;

	struct net *net;



	/* no diff required for incoming packets */

	*diff = 0;



#ifdef CONFIG_IP_VS_IPV6

	/* This application helper doesn't work with IPv6 yet,

	 * so turn this into a no-op for IPv6 packets
@@ -330,9 +333,6 @@ static int ip_vs_ftp_in(struct ip_vs_app *app, struct ip_vs_conn *cp, 
		return 1;

#endif



	/* no diff required for incoming packets */

	*diff = 0;



	/* Only useful for established sessions */

	if (cp->state != IP_VS_TCP_S_ESTABLISHED)

		return 1;