Commit 3a4462e0 authored Nov 14, 2013 by Hans de Goede Committed by Sarah Sharp Mar 04, 2014

uas: Clear cmdinfo on command queue-ing



The scsi error handling path re-uses previously queued up (and errored-out)
cmds. If such a re-used cmd had a data-phase then cmdinfo will have
data_in_urb / data_out_urb still set to the free-ed urbs from the errored-out
cmd, and they will get free-ed a second time when the error handling cmd
completes, corrupting the kernel heap.

Clearing cmdinfo on command queue-ing fixes this, and seems like a good idea
in general.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>

parent 21fc05b6

drivers/usb/storage/uas.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -684,6 +684,8 @@ static int uas_queuecommand_lck(struct scsi_cmnd *cmnd,
		return SCSI_MLQUEUE_DEVICE_BUSY;
		}

		memset(cmdinfo, 0, sizeof(*cmdinfo));

		if (blk_rq_tagged(cmnd->request)) {
		cmdinfo->stream = cmnd->request->tag + 2;
		} else {