Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3a229b39 authored by Andrew Morton's avatar Andrew Morton Committed by Linus Torvalds
Browse files

[PATCH] ext3: uninline large functions 



Saves nearly 4kbytes on x86.

Cc: Arnaldo Carvalho de Melo <acme@mandriva.com>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 07233058

fs/ext3/Makefile

+1 −1
Original line number Diff line number Diff line
@@ -5,7 +5,7 @@ 
obj-$(CONFIG_EXT3_FS) += ext3.o



ext3-y	:= balloc.o bitmap.o dir.o file.o fsync.o ialloc.o inode.o \

	   ioctl.o namei.o super.o symlink.o hash.o resize.o

	   ioctl.o namei.o super.o symlink.o hash.o resize.o ext3_jbd.o



ext3-$(CONFIG_EXT3_FS_XATTR)	 += xattr.o xattr_user.o xattr_trusted.o

ext3-$(CONFIG_EXT3_FS_POSIX_ACL) += acl.o

fs/ext3/ext3_jbd.c

0 → 100644
+59 −0
Original line number Diff line number Diff line 
/*

 * Interface between ext3 and JBD

 */



#include <linux/ext3_jbd.h>



int __ext3_journal_get_undo_access(const char *where, handle_t *handle,

				struct buffer_head *bh)

{

	int err = journal_get_undo_access(handle, bh);

	if (err)

		ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);

	return err;

}



int __ext3_journal_get_write_access(const char *where, handle_t *handle,

				struct buffer_head *bh)

{

	int err = journal_get_write_access(handle, bh);

	if (err)

		ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);

	return err;

}



int __ext3_journal_forget(const char *where, handle_t *handle,

				struct buffer_head *bh)

{

	int err = journal_forget(handle, bh);

	if (err)

		ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);

	return err;

}



int __ext3_journal_revoke(const char *where, handle_t *handle,

				unsigned long blocknr, struct buffer_head *bh)

{

	int err = journal_revoke(handle, blocknr, bh);

	if (err)

		ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);

	return err;

}



int __ext3_journal_get_create_access(const char *where,

				handle_t *handle, struct buffer_head *bh)

{

	int err = journal_get_create_access(handle, bh);

	if (err)

		ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);

	return err;

}



int __ext3_journal_dirty_metadata(const char *where,

				handle_t *handle, struct buffer_head *bh)

{

	int err = journal_dirty_metadata(handle, bh);

	if (err)

		ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);

	return err;

}

include/linux/ext3_jbd.h

+17 −59
Original line number Diff line number Diff line
@@ -109,74 +109,32 @@ int ext3_mark_inode_dirty(handle_t *handle, struct inode *inode); 
 * been done yet.

 */



void ext3_journal_abort_handle(const char *caller, const char *err_fn,

		struct buffer_head *bh, handle_t *handle, int err);



static inline int

__ext3_journal_get_undo_access(const char *where, handle_t *handle,

static inline void ext3_journal_release_buffer(handle_t *handle,

						struct buffer_head *bh)

{

	int err = journal_get_undo_access(handle, bh);

	if (err)

		ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);

	return err;

	journal_release_buffer(handle, bh);

}



static inline int

__ext3_journal_get_write_access(const char *where, handle_t *handle,

				struct buffer_head *bh)

{

	int err = journal_get_write_access(handle, bh);

	if (err)

		ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);

	return err;

}

void ext3_journal_abort_handle(const char *caller, const char *err_fn,

		struct buffer_head *bh, handle_t *handle, int err);



static inline void

ext3_journal_release_buffer(handle_t *handle, struct buffer_head *bh)

{

	journal_release_buffer(handle, bh);

}

int __ext3_journal_get_undo_access(const char *where, handle_t *handle,

				struct buffer_head *bh);



static inline int

__ext3_journal_forget(const char *where, handle_t *handle, struct buffer_head *bh)

{

	int err = journal_forget(handle, bh);

	if (err)

		ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);

	return err;

}

int __ext3_journal_get_write_access(const char *where, handle_t *handle,

				struct buffer_head *bh);



static inline int

__ext3_journal_revoke(const char *where, handle_t *handle,

		      unsigned long blocknr, struct buffer_head *bh)

{

	int err = journal_revoke(handle, blocknr, bh);

	if (err)

		ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);

	return err;

}

int __ext3_journal_forget(const char *where, handle_t *handle,

				struct buffer_head *bh);



static inline int

__ext3_journal_get_create_access(const char *where,

				 handle_t *handle, struct buffer_head *bh)

{

	int err = journal_get_create_access(handle, bh);

	if (err)

		ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);

	return err;

}

int __ext3_journal_revoke(const char *where, handle_t *handle,

				unsigned long blocknr, struct buffer_head *bh);



static inline int

__ext3_journal_dirty_metadata(const char *where,

			      handle_t *handle, struct buffer_head *bh)

{

	int err = journal_dirty_metadata(handle, bh);

	if (err)

		ext3_journal_abort_handle(where, __FUNCTION__, bh, handle,err);

	return err;

}

int __ext3_journal_get_create_access(const char *where,

				handle_t *handle, struct buffer_head *bh);



int __ext3_journal_dirty_metadata(const char *where,

				handle_t *handle, struct buffer_head *bh);



#define ext3_journal_get_undo_access(handle, bh) \

	__ext3_journal_get_undo_access(__FUNCTION__, (handle), (bh))