Commit 3a11c0e1 authored Dec 29, 2016 by Colin Ian King Committed by Dmitry Torokhov Dec 29, 2016

Input: synaptics-rmi4 - remove redundant null check on rmi_dev



rmi_dev is currently being dereferenced before it null checked, however,
after deeper inspecting, rmi_dev can never be null, so just remove this
redundant check.

Fixes CoverityScan CID 1391218 ("Dereference before null check")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

parent 0c54fe74

drivers/input/rmi4/rmi_f03.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -175,9 +175,6 @@ static int rmi_f03_attention(struct rmi_function fn, unsigned long irq_bits)
		int i;
		int error;

		if (!rmi_dev)
		return -ENODEV;

		if (drvdata->attn_data.data) {
		/* First grab the data passed by the transport device */
		if (drvdata->attn_data.size < ob_len) {