Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3984ca1c authored by Stephen Hemminger's avatar Stephen Hemminger Committed by Bjorn Helgaas
Browse files

PCI: Remove unused pci_vpd_truncate() 



My philosophy is unused code is dead code.  And dead code is subject to bit
rot and is a likely source of bugs.  Use it or lose it.

This reverts db567943 ("PCI: add interface to set visible size of
VPD"), removing this interface:

    pci_vpd_truncate()

[bhelgaas: split to separate patch, also remove prototype from pci.h]
Signed-off-by: default avatarStephen Hemminger <stephen@networkplumber.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 7c2dd2d7

drivers/pci/access.c

+0 −24
Original line number Diff line number Diff line
@@ -380,30 +380,6 @@ int pci_vpd_pci22_init(struct pci_dev *dev) 
	return 0;

}



/**

 * pci_vpd_truncate - Set available Vital Product Data size

 * @dev:	pci device struct

 * @size:	available memory in bytes

 *

 * Adjust size of available VPD area.

 */

int pci_vpd_truncate(struct pci_dev *dev, size_t size)

{

	if (!dev->vpd)

		return -EINVAL;



	/* limited by the access method */

	if (size > dev->vpd->len)

		return -EINVAL;



	dev->vpd->len = size;

	if (dev->vpd->attr)

		dev->vpd->attr->size = size;



	return 0;

}

EXPORT_SYMBOL(pci_vpd_truncate);



/**

 * pci_cfg_access_lock - Lock PCI config reads/writes

 * @dev:	pci device struct

include/linux/pci.h

+0 −1
Original line number Diff line number Diff line
@@ -1009,7 +1009,6 @@ unsigned int pci_rescan_bus(struct pci_bus *bus); 
/* Vital product data routines */

ssize_t pci_read_vpd(struct pci_dev *dev, loff_t pos, size_t count, void *buf);

ssize_t pci_write_vpd(struct pci_dev *dev, loff_t pos, size_t count, const void *buf);

int pci_vpd_truncate(struct pci_dev *dev, size_t size);



/* Helper functions for low-level code (drivers/pci/setup-[bus,res].c) */

resource_size_t pcibios_retrieve_fw_addr(struct pci_dev *dev, int idx);