Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 38992c57 authored by Jyri Sarha's avatar Jyri Sarha Committed by Thierry Reding
Browse files

drm/panel: Remove drm_panel_detach() calls from all panel drivers 



Remove all drm_panel_detach() calls from all panel drivers and update
the kerneldoc for drm_panel_detach().

Setting the connector and drm to NULL when the DRM panel device is going
away hardly serves any purpose. Usually the whole memory structure is
freed right after the remove call. However, calling the detach function
from the master DRM device, and setting the connector pointer to NULL,
has the logic of marking the panel again as available for another DRM
master to attach. The usual situation would be the same DRM master
device binding again.

Signed-off-by: default avatarJyri Sarha <jsarha@ti.com>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/464b8d330d6b4c94cfb5aad2ca9ea7eb2c52d934.1524727888.git.jsarha@ti.com
parent 6553b123

drivers/gpu/drm/drm_panel.c

+6 −0
Original line number Diff line number Diff line
@@ -94,6 +94,9 @@ EXPORT_SYMBOL(drm_panel_remove); 
 *

 * An error is returned if the panel is already attached to another connector.

 *

 * When unloading, the driver should detach from the panel by calling

 * drm_panel_detach().

 *

 * Return: 0 on success or a negative error code on failure.

 */

int drm_panel_attach(struct drm_panel *panel, struct drm_connector *connector)
@@ -115,6 +118,9 @@ EXPORT_SYMBOL(drm_panel_attach); 
 * Detaches a panel from the connector it is attached to. If a panel is not

 * attached to any connector this is effectively a no-op.

 *

 * This function should not be called by the panel device itself. It

 * is only for the drm device that called drm_panel_attach().

 *

 * Return: 0 on success or a negative error code on failure.

 */

int drm_panel_detach(struct drm_panel *panel)

drivers/gpu/drm/panel/panel-innolux-p079zca.c

+0 −1
Original line number Diff line number Diff line
@@ -292,7 +292,6 @@ static int innolux_panel_remove(struct mipi_dsi_device *dsi) 
		DRM_DEV_ERROR(&dsi->dev, "failed to detach from DSI host: %d\n",

			      err);



	drm_panel_detach(&innolux->base);

	innolux_panel_del(innolux);



	return 0;

drivers/gpu/drm/panel/panel-jdi-lt070me05000.c

+0 −1
Original line number Diff line number Diff line
@@ -500,7 +500,6 @@ static int jdi_panel_remove(struct mipi_dsi_device *dsi) 
		dev_err(&dsi->dev, "failed to detach from DSI host: %d\n",

			ret);



	drm_panel_detach(&jdi->base);

	jdi_panel_del(jdi);



	return 0;

drivers/gpu/drm/panel/panel-lvds.c

+0 −1
Original line number Diff line number Diff line
@@ -282,7 +282,6 @@ static int panel_lvds_remove(struct platform_device *pdev) 
{

	struct panel_lvds *lvds = dev_get_drvdata(&pdev->dev);



	drm_panel_detach(&lvds->panel);

	drm_panel_remove(&lvds->panel);



	panel_lvds_disable(&lvds->panel);

drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c

+0 −1
Original line number Diff line number Diff line
@@ -299,7 +299,6 @@ static int wuxga_nt_panel_remove(struct mipi_dsi_device *dsi) 
	if (ret < 0)

		dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret);



	drm_panel_detach(&wuxga_nt->base);

	wuxga_nt_panel_del(wuxga_nt);



	return 0;