Commit 38460809 authored Feb 25, 2019 by Vlad Buslov Committed by Greg Kroah-Hartman Mar 10, 2019

net: sched: act_tunnel_key: fix NULL pointer dereference during init



[ Upstream commit a3df633a3c92bb96b06552c3f828d7c267774379 ]

Metadata pointer is only initialized for action TCA_TUNNEL_KEY_ACT_SET, but
it is unconditionally dereferenced in tunnel_key_init() error handler.
Verify that metadata pointer is not NULL before dereferencing it in
tunnel_key_init error handling code.

Fixes: ee28bb56 ("net/sched: fix memory leak in act_tunnel_key_init()")
Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Reviewed-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 69e6fb18

net/sched/act_tunnel_key.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -377,6 +377,7 @@ static int tunnel_key_init(struct net net, struct nlattr nla,
		return ret;

		release_tun_meta:
		if (metadata)
		dst_release(&metadata->dst);

		err_out: