Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 37c52934 authored by Larry Finger's avatar Larry Finger Committed by Kalle Valo
Browse files

rtlwifi: Fix Smatch warnings 



Smatch reports the following:

  CHECK   drivers/net/wireless/realtek/rtlwifi/pci.c
drivers/net/wireless/realtek/rtlwifi/pci.c:366 rtl_pci_check_buddy_priv() error: we previously assumed 'tpriv' could be null (see line 368)
drivers/net/wireless/realtek/rtlwifi/pci.c:1216 _rtl_pci_init_struct() warn: inconsistent indenting

Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent baa17022

drivers/net/wireless/realtek/rtlwifi/pci.c

+19 −20
Original line number Diff line number Diff line
@@ -359,13 +359,12 @@ static bool rtl_pci_check_buddy_priv(struct ieee80211_hw *hw, 
	struct rtl_priv *rtlpriv = rtl_priv(hw);

	struct rtl_pci_priv *pcipriv = rtl_pcipriv(hw);

	bool find_buddy_priv = false;

	struct rtl_priv *tpriv = NULL;

	struct rtl_priv *tpriv;

	struct rtl_pci_priv *tpcipriv = NULL;



	if (!list_empty(&rtlpriv->glb_var->glb_priv_list)) {

		list_for_each_entry(tpriv, &rtlpriv->glb_var->glb_priv_list,

				    list) {

			if (tpriv) {

			tpcipriv = (struct rtl_pci_priv *)tpriv->priv;

			RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,

				 "pcipriv->ndis_adapter.funcnumber %x\n",
@@ -385,7 +384,6 @@ static bool rtl_pci_check_buddy_priv(struct ieee80211_hw *hw, 
			}

		}

	}

	}



	RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD,

		 "find_buddy_priv %d\n", find_buddy_priv);
@@ -1213,7 +1211,8 @@ static void _rtl_pci_init_struct(struct ieee80211_hw *hw, 
	/*Tx/Rx related var */

	_rtl_pci_init_trx_var(hw);



	/*IBSS*/ mac->beacon_interval = 100;

	/*IBSS*/

	mac->beacon_interval = 100;



	/*AMPDU*/

	mac->min_space_cfg = 0;