Commit 37b617f9 authored Jul 11, 2015 by Christian Engelmayer Committed by Tomi Valkeinen Aug 10, 2015

video: Fix possible leak in of_get_videomode()



In case videomode_from_timings() fails in function of_get_videomode(), the
allocated display timing data is not freed in the exit path. Make sure that
display_timings_release() is called in any case. Detected by Coverity CID
1309681.

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

parent 9e6e35ed

drivers/video/of_videomode.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -44,11 +44,9 @@ int of_get_videomode(struct device_node np, struct videomode vm,
		index = disp->native_mode;

		ret = videomode_from_timings(disp, vm, index);
		if (ret)
		return ret;

		display_timings_release(disp);

		return 0;
		return ret;
		}
		EXPORT_SYMBOL_GPL(of_get_videomode);