Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 376a588c authored by Bob Moore's avatar Bob Moore Committed by Rafael J. Wysocki
Browse files

ACPICA: Ensure all instances of AE_AML_INTERNAL have error messages 

ACPICA commit ea9152daaec30760fa4c25285998f58233ec0db5

This exception is only meaningful with an associated error message.

Link: https://github.com/acpica/acpica/commit/ea9152da


Signed-off-by: default avatarBob Moore <robert.moore@intel.com>
Signed-off-by: default avatarLv Zheng <lv.zheng@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent a62a7117

drivers/acpi/acpica/dsfield.c

+2 −0
Original line number Diff line number Diff line
@@ -184,6 +184,7 @@ acpi_ds_create_buffer_field(union acpi_parse_object *op, 
		/* Execute flag should always be set when this function is entered */



		if (!(walk_state->parse_flags & ACPI_PARSE_EXECUTE)) {

			ACPI_ERROR((AE_INFO, "Parse execute mode is not set"));

			return_ACPI_STATUS(AE_AML_INTERNAL);

		}
@@ -556,6 +557,7 @@ acpi_ds_init_field_objects(union acpi_parse_object *op, 
			return_ACPI_STATUS(AE_OK);

		}



		ACPI_ERROR((AE_INFO, "Parse deferred mode is not set"));

		return_ACPI_STATUS(AE_AML_INTERNAL);

	}

drivers/acpi/acpica/exmisc.c

+9 −0
Original line number Diff line number Diff line
@@ -265,6 +265,8 @@ acpi_ex_do_logical_numeric_op(u16 opcode, 


	default:



		ACPI_ERROR((AE_INFO,

			    "Invalid numeric logical opcode: %X", opcode));

		status = AE_AML_INTERNAL;

		break;

	}
@@ -345,6 +347,9 @@ acpi_ex_do_logical_op(u16 opcode, 


	default:



		ACPI_ERROR((AE_INFO,

			    "Invalid object type for logical operator: %X",

			    operand0->common.type));

		status = AE_AML_INTERNAL;

		break;

	}
@@ -388,6 +393,8 @@ acpi_ex_do_logical_op(u16 opcode, 


		default:



			ACPI_ERROR((AE_INFO,

				    "Invalid comparison opcode: %X", opcode));

			status = AE_AML_INTERNAL;

			break;

		}
@@ -456,6 +463,8 @@ acpi_ex_do_logical_op(u16 opcode, 


		default:



			ACPI_ERROR((AE_INFO,

				    "Invalid comparison opcode: %X", opcode));

			status = AE_AML_INTERNAL;

			break;

		}

drivers/acpi/acpica/exoparg2.c

+3 −0
Original line number Diff line number Diff line
@@ -414,6 +414,9 @@ acpi_status acpi_ex_opcode_2A_1T_1R(struct acpi_walk_state *walk_state) 


		default:



			ACPI_ERROR((AE_INFO,

				    "Invalid object type: %X",

				    (operand[0])->common.type));

			status = AE_AML_INTERNAL;

			goto cleanup;

		}

drivers/acpi/acpica/nsprepkg.c

+2 −0
Original line number Diff line number Diff line
@@ -614,6 +614,8 @@ acpi_ns_check_package_list(struct acpi_evaluate_info *info, 


		default:	/* Should not get here, type was validated by caller */



			ACPI_ERROR((AE_INFO, "Invalid Package type: %X",

				    package->ret_info.type));

			return (AE_AML_INTERNAL);

		}

drivers/acpi/acpica/utmisc.c

+2 −0
Original line number Diff line number Diff line
@@ -341,6 +341,8 @@ acpi_ut_walk_package_tree(union acpi_operand_object *source_object, 


	/* We should never get here */



	ACPI_ERROR((AE_INFO, "State list did not terminate correctly"));



	return_ACPI_STATUS(AE_AML_INTERNAL);

}