Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 36f3a6e0 authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Takashi Iwai
Browse files

ALSA: fireface: fix memory leak in ff400_switch_fetching_mode() 



An allocated memory forgets to be released.

Fixes: 76fdb3a9 ('ALSA: fireface: add support for Fireface 400')
Cc: <stable@vger.kernel.org> # 4.12+
Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 493626f2

sound/firewire/fireface/ff-protocol-ff400.c

+6 −3
Original line number Diff line number Diff line
@@ -146,6 +146,7 @@ static int ff400_switch_fetching_mode(struct snd_ff *ff, bool enable) 
{

	__le32 *reg;

	int i;

	int err;



	reg = kcalloc(18, sizeof(__le32), GFP_KERNEL);

	if (reg == NULL)
@@ -163,9 +164,11 @@ static int ff400_switch_fetching_mode(struct snd_ff *ff, bool enable) 
			reg[i] = cpu_to_le32(0x00000001);

	}



	return snd_fw_transaction(ff->unit, TCODE_WRITE_BLOCK_REQUEST,

	err = snd_fw_transaction(ff->unit, TCODE_WRITE_BLOCK_REQUEST,

				 FF400_FETCH_PCM_FRAMES, reg,

				 sizeof(__le32) * 18, 0);

	kfree(reg);

	return err;

}



static void ff400_dump_sync_status(struct snd_ff *ff,