Commit 36b6458d authored Jul 15, 2019 by Laura Garcia Liebana Committed by Greg Kroah-Hartman Aug 16, 2019

netfilter: nft_hash: fix symhash with modulus one



[ Upstream commit 28b1d6ef53e3303b90ca8924bb78f31fa527cafb ]

The rule below doesn't work as the kernel raises -ERANGE.

nft add rule netdev nftlb lb01 ip daddr set \
	symhash mod 1 map { 0 : 192.168.0.10 } fwd to "eth0"

This patch allows to use the symhash modulus with one
element, in the same way that the other types of hashes and
algorithms that uses the modulus parameter.

Signed-off-by: Laura Garcia Liebana <nevola@gmail.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 6f1d7f0d

net/netfilter/nft_hash.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -196,7 +196,7 @@ static int nft_symhash_init(const struct nft_ctx *ctx,
		priv->dreg = nft_parse_register(tb[NFTA_HASH_DREG]);

		priv->modulus = ntohl(nla_get_be32(tb[NFTA_HASH_MODULUS]));
		if (priv->modulus <= 1)
		if (priv->modulus < 1)
		return -ERANGE;

		if (priv->offset + priv->modulus - 1 < priv->offset)