Commit 36b4894e authored Mar 01, 2017 by Aishwarya Pant Committed by Greg Kroah-Hartman Mar 06, 2017

staging: bcm2835-camera: prefer allocating memory using sizeof(*ptr) instead...


staging: bcm2835-camera: prefer allocating memory using sizeof(*ptr) instead of sizeof(struct type name)

Using sizeof(*ptr) instead of sizeof(struct type name) is more robust to
errors.

Signed-off-by: Aishwarya Pant <aishpant@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 16255382

drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1908,7 +1908,7 @@ static int __init bm2835_mmal_init(void)
		num_cameras = MAX_BCM2835_CAMERAS;

		for (camera = 0; camera < num_cameras; camera++) {
		dev = kzalloc(sizeof(struct bm2835_mmal_dev), GFP_KERNEL);
		dev = kzalloc(sizeof(*dev), GFP_KERNEL);
		if (!dev) {
		ret = -ENOMEM;
		goto cleanup_gdev;