Commit 369421cb authored Jun 28, 2017 by Christian König Committed by Alex Deucher Jul 14, 2017

drm/amdgpu: fix amdgpu_ring_write_multiple



Overwriting still used ring content has a low probability to cause
problems, not writing at all has 100% probability to cause problems.

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Acked-by: Felix Kuehling <Felix.Kuehling@amd.com>

parent e8110b1c

drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h

+1 −3

Original line number	Diff line number	Diff line
		@@ -227,10 +227,8 @@ static inline void amdgpu_ring_write_multiple(struct amdgpu_ring *ring,
		unsigned occupied, chunk1, chunk2;
		void *dst;

		if (unlikely(ring->count_dw < count_dw)) {
		if (unlikely(ring->count_dw < count_dw))
		DRM_ERROR("amdgpu: writing more dwords to the ring than expected!\n");
		return;
		}

		occupied = ring->wptr & ring->buf_mask;
		dst = (void *)&ring->ring[occupied];