Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 36141e56 authored by Peter Senna Tschudin's avatar Peter Senna Tschudin Committed by Florian Tobias Schandinat
Browse files

drivers/video/exynos/exynos_mipi_dsi.c: fix error return code 

Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: default avatarPeter Senna Tschudin <peter.senna@gmail.com>
Acked-by: default avatarDonghwa Lee <dh09.lee@samsung.com>
Signed-off-by: default avatarFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
parent d63f2c53

drivers/video/exynos/exynos_mipi_dsi.c

+3 −0
Original line number Diff line number Diff line
@@ -375,6 +375,7 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev) 
	dsim->clock = clk_get(&pdev->dev, "dsim0");

	if (IS_ERR(dsim->clock)) {

		dev_err(&pdev->dev, "failed to get dsim clock source\n");

		ret = -ENODEV;

		goto err_clock_get;

	}
@@ -383,6 +384,7 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev) 
	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	if (!res) {

		dev_err(&pdev->dev, "failed to get io memory region\n");

		ret = -ENODEV;

		goto err_platform_get;

	}
@@ -407,6 +409,7 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev) 
	dsim_ddi = exynos_mipi_dsi_bind_lcd_ddi(dsim, dsim_pd->lcd_panel_name);

	if (!dsim_ddi) {

		dev_err(&pdev->dev, "mipi_dsim_ddi object not found.\n");

		ret = -EINVAL;

		goto err_bind;

	}