Commit 35f07497 authored Aug 04, 2023 by Su Hui Committed by Greg Kroah-Hartman Sep 23, 2023

fs: lockd: avoid possible wrong NULL parameter



[ Upstream commit de8d38cf44bac43e83bad28357ba84784c412752 ]

clang's static analysis warning: fs/lockd/mon.c: line 293, column 2:
Null pointer passed as 2nd argument to memory copy function.

Assuming 'hostname' is NULL and calling 'nsm_create_handle()', this will
pass NULL as 2nd argument to memory copy function 'memcpy()'. So return
NULL if 'hostname' is invalid.

Fixes: 77a3ef33 ("NSM: More clean up of nsm_get_handle()")
Signed-off-by: Su Hui <suhui@nfschina.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 2f07fe5d

fs/lockd/mon.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -275,6 +275,9 @@ static struct nsm_handle nsm_create_handle(const struct sockaddr sap,
		{
		struct nsm_handle *new;

		if (!hostname)
		return NULL;

		new = kzalloc(sizeof(*new) + hostname_len + 1, GFP_KERNEL);
		if (unlikely(new == NULL))
		return NULL;