Commit 35b2719e authored Mar 08, 2017 by Felipe Balbi

usb: dwc3: gadget: make to increment req->remaining in all cases



Sometimes, we might get a completion for a TRB which is left with HWO
bit. Even in these cases, we should increment req->remaining to
properly report total transferred size. I noticed this while debuggin
a separate problem seen with MSC tests from USBCV. Sometimes we would
erroneously report a completion for a 512-byte transfer when, in
reality, we transferred 0 bytes.

Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>

parent ef5e2fa9

drivers/usb/dwc3/gadget.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -2189,12 +2189,12 @@ static int __dwc3_cleanup_done_trbs(struct dwc3 dwc, struct dwc3_ep dep,
		return 1;
		}

		if ((trb->ctrl & DWC3_TRB_CTRL_HWO) && status != -ESHUTDOWN)
		return 1;

		count = trb->size & DWC3_TRB_SIZE_MASK;
		req->remaining += count;

		if ((trb->ctrl & DWC3_TRB_CTRL_HWO) && status != -ESHUTDOWN)
		return 1;

		if (dep->direction) {
		if (count) {
		trb_status = DWC3_TRB_SIZE_TRBSTS(trb->size);