Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 35b123e2 authored by Andreea-Cristina Bernat's avatar Andreea-Cristina Bernat Committed by Ingo Molnar
Browse files

sched/fair: Replace rcu_assign_pointer() with RCU_INIT_POINTER() 



The use of "rcu_assign_pointer()" is NULLing out the pointer.
According to RCU_INIT_POINTER()'s block comment:

  "1.   This use of RCU_INIT_POINTER() is NULLing out the pointer"

it is better to use it instead of rcu_assign_pointer() because it has a
smaller overhead.

The following Coccinelle semantic patch was used:
 @@
 @@

 - rcu_assign_pointer
 + RCU_INIT_POINTER
   (..., NULL)

Signed-off-by: default avatarAndreea-Cristina Bernat <bernat.ada@gmail.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: paulmck@linux.vnet.ibm.com
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/20140822145043.GA580@ada


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 163122b7

kernel/sched/fair.c

+1 −1
Original line number Diff line number Diff line
@@ -1780,7 +1780,7 @@ void task_numa_free(struct task_struct *p) 
		list_del(&p->numa_entry);

		grp->nr_tasks--;

		spin_unlock_irqrestore(&grp->lock, flags);

		rcu_assign_pointer(p->numa_group, NULL);

		RCU_INIT_POINTER(p->numa_group, NULL);

		put_numa_group(grp);

	}