Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 35a7f41c authored by Wei Yongjun's avatar Wei Yongjun Committed by Michael Ellerman
Browse files

powerpc/4xx: Fix return value check in hsta_msi_probe() 



In case of error, the functions platform_get_resource() and kmalloc()
returns NULL not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent a368c29c

arch/powerpc/sysdev/ppc4xx_hsta_msi.c

+2 −2
Original line number Diff line number Diff line
@@ -132,7 +132,7 @@ static int hsta_msi_probe(struct platform_device *pdev) 
	struct pci_controller *phb;



	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	if (IS_ERR(mem)) {

	if (!mem) {

		dev_err(dev, "Unable to get mmio space\n");

		return -EINVAL;

	}
@@ -157,7 +157,7 @@ static int hsta_msi_probe(struct platform_device *pdev) 
		goto out;



	ppc4xx_hsta_msi.irq_map = kmalloc(sizeof(int) * irq_count, GFP_KERNEL);

	if (IS_ERR(ppc4xx_hsta_msi.irq_map)) {

	if (!ppc4xx_hsta_msi.irq_map) {

		ret = -ENOMEM;

		goto out1;

	}