Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 359cecdd authored by Yong Zhao's avatar Yong Zhao Committed by Oded Gabbay
Browse files

drm/amdkfd: Optimize out some duplicated code in kfd_signal_iommu_event() 



memory_exception_data is already initialized for not-present faults.
It only needs to be overridden for permission faults.

Signed-off-by: default avatarYong Zhao <yong.zhao@amd.com>
Reviewed-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: default avatarFelix Kuehling <Felix.Kuehling@amd.com>
Acked-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarOded Gabbay <oded.gabbay@gmail.com>
parent 8725aeca

drivers/gpu/drm/amd/amdkfd/kfd_events.c

+11 −15
Original line number Diff line number Diff line
@@ -911,23 +911,19 @@ void kfd_signal_iommu_event(struct kfd_dev *dev, unsigned int pasid, 
	memory_exception_data.failure.NotPresent = 1;

	memory_exception_data.failure.NoExecute = 0;

	memory_exception_data.failure.ReadOnly = 0;

	if (vma) {

		if (vma->vm_start > address) {

			memory_exception_data.failure.NotPresent = 1;

			memory_exception_data.failure.NoExecute = 0;

			memory_exception_data.failure.ReadOnly = 0;

		} else {

	if (vma && address >= vma->vm_start) {

		memory_exception_data.failure.NotPresent = 0;



		if (is_write_requested && !(vma->vm_flags & VM_WRITE))

			memory_exception_data.failure.ReadOnly = 1;

		else

			memory_exception_data.failure.ReadOnly = 0;



		if (is_execute_requested && !(vma->vm_flags & VM_EXEC))

			memory_exception_data.failure.NoExecute = 1;

		else

			memory_exception_data.failure.NoExecute = 0;

	}

	}



	up_read(&mm->mmap_sem);

	mmput(mm);