Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 358399f8 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Ulf Hansson
Browse files

mmc: omap_hsmmc: don't print uninitialized variables 



When DT based probing is used but the DMA request fails, the
driver will print uninitialized stack data from the rx_req
and tx_req variables, as indicated by this warning:

drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_probe':
drivers/mmc/host/omap_hsmmc.c:2162:3: warning: 'rx_req' may be used uninitialized in this function [-Wmaybe-uninitialized]
   dev_err(mmc_dev(host->mmc), "unable to obtain RX DMA engine channel %u\n", rx_req);

This removes the DMA request line number from the warning, which
is the easiest solution and won't hurt us any more as we are
planning to remove the legacy code path anyway.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Acked-by: default avatarTony Lindgren <tony@atomide.com>
Reviewed-by: default avatarPeter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 4e6a2ef9

drivers/mmc/host/omap_hsmmc.c

+2 −2
Original line number Diff line number Diff line
@@ -2162,7 +2162,7 @@ static int omap_hsmmc_probe(struct platform_device *pdev) 
						 &rx_req, &pdev->dev, "rx");



	if (!host->rx_chan) {

		dev_err(mmc_dev(host->mmc), "unable to obtain RX DMA engine channel %u\n", rx_req);

		dev_err(mmc_dev(host->mmc), "unable to obtain RX DMA engine channel\n");

		ret = -ENXIO;

		goto err_irq;

	}
@@ -2172,7 +2172,7 @@ static int omap_hsmmc_probe(struct platform_device *pdev) 
						 &tx_req, &pdev->dev, "tx");



	if (!host->tx_chan) {

		dev_err(mmc_dev(host->mmc), "unable to obtain TX DMA engine channel %u\n", tx_req);

		dev_err(mmc_dev(host->mmc), "unable to obtain TX DMA engine channel\n");

		ret = -ENXIO;

		goto err_irq;

	}