Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 350a5147 authored by Sebastien Alaiwan's avatar Sebastien Alaiwan Committed by Takashi Iwai
Browse files

ALSA: ice1712: fix: lock samplerate when samplerate locking is enabled 



I found that the sampling rate locking setting of the ice1712 sound driver
was only half-respected : when the driver was locked to, let's say, 44100Hz,
and a usermode app was requesting 48000Hz playback, the request was succesful
although the soundcard would continue to run at 44100Hz.

Here's a patch that will make those requests to fail.

Signed-off-by: default avatarSebastien Alaiwan <sebastien.alaiwan@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent c85a4004

sound/pci/ice1712/ice1712.c

+9 −0
Original line number Diff line number Diff line
@@ -1180,6 +1180,10 @@ static int snd_ice1712_playback_pro_open(struct snd_pcm_substream *substream) 
	snd_pcm_set_sync(substream);

	snd_pcm_hw_constraint_msbits(runtime, 0, 32, 24);

	snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_RATE, &hw_constraints_rates);

	if (is_pro_rate_locked(ice)) {

		runtime->hw.rate_min = PRO_RATE_DEFAULT;

		runtime->hw.rate_max = PRO_RATE_DEFAULT;

	}



	if (ice->spdif.ops.open)

		ice->spdif.ops.open(ice, substream);
@@ -1197,6 +1201,11 @@ static int snd_ice1712_capture_pro_open(struct snd_pcm_substream *substream) 
	snd_pcm_set_sync(substream);

	snd_pcm_hw_constraint_msbits(runtime, 0, 32, 24);

	snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_RATE, &hw_constraints_rates);

	if (is_pro_rate_locked(ice)) {

		runtime->hw.rate_min = PRO_RATE_DEFAULT;

		runtime->hw.rate_max = PRO_RATE_DEFAULT;

	}



	return 0;

}