Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 34e44fe8 authored by Rajendra Nayak's avatar Rajendra Nayak Committed by Mike Turquette
Browse files

clk: Make clk_get_rate() return 0 on error 



Most users of clk_get_rate() actually assume a non zero
return value as a valid rate returned. Returing -EINVAL
might confuse such users, so make it instead return zero
on error.

Besides the return value of clk_get_rate seems to be
'unsigned long'.

Signed-off-by: default avatarRajendra nayak <rnayak@ti.com>
Signed-off-by: default avatarMike Turquette <mturquette@linaro.org>
parent bffad66e

drivers/clk/clk.c

+3 −3
Original line number Original line Diff line number Diff line
@@ -285,7 +285,7 @@ unsigned long __clk_get_rate(struct clk *clk) 
	unsigned long ret;

	unsigned long ret;





	if (!clk) {

	if (!clk) {

		ret = -EINVAL;

		ret = 0;

		goto out;

		goto out;

	}

	}
@@ -295,7 +295,7 @@ unsigned long __clk_get_rate(struct clk *clk) 
		goto out;

		goto out;





	if (!clk->parent)

	if (!clk->parent)

		ret = -ENODEV;

		ret = 0;





out:

out:

	return ret;

	return ret;
@@ -560,7 +560,7 @@ EXPORT_SYMBOL_GPL(clk_enable); 
 * @clk: the clk whose rate is being returned

 * @clk: the clk whose rate is being returned

 *

 *

 * Simply returns the cached rate of the clk.  Does not query the hardware.  If

 * Simply returns the cached rate of the clk.  Does not query the hardware.  If

 * clk is NULL then returns -EINVAL.

 * clk is NULL then returns 0.

 */

 */

unsigned long clk_get_rate(struct clk *clk)

unsigned long clk_get_rate(struct clk *clk)

{

{