Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 346fa83d authored by zhong jiang's avatar zhong jiang Committed by Pablo Neira Ayuso
Browse files

netfilter: conntrack: get rid of double sizeof 



sizeof(sizeof()) is quite strange and does not seem to be what
is wanted here.

The issue is detected with the help of Coccinelle.

Fixes: 39215846 ("netfilter: conntrack: remove nlattr_size pointer from l4proto trackers")
Signed-off-by: default avatarzhong jiang <zhongjiang@huawei.com>
Acked-by: default avatarFlorian Westphal <fw@strlen.de>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent bab43449

net/netfilter/nf_conntrack_proto_tcp.c

+2 −2
Original line number Diff line number Diff line
@@ -1213,8 +1213,8 @@ static const struct nla_policy tcp_nla_policy[CTA_PROTOINFO_TCP_MAX+1] = { 
#define TCP_NLATTR_SIZE	( \

	NLA_ALIGN(NLA_HDRLEN + 1) + \

	NLA_ALIGN(NLA_HDRLEN + 1) + \

	NLA_ALIGN(NLA_HDRLEN + sizeof(sizeof(struct nf_ct_tcp_flags))) + \

	NLA_ALIGN(NLA_HDRLEN + sizeof(sizeof(struct nf_ct_tcp_flags))))

	NLA_ALIGN(NLA_HDRLEN + sizeof(struct nf_ct_tcp_flags)) + \

	NLA_ALIGN(NLA_HDRLEN + sizeof(struct nf_ct_tcp_flags)))



static int nlattr_to_tcp(struct nlattr *cda[], struct nf_conn *ct)

{