Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 343e4fc1 authored by Liu Bo's avatar Liu Bo Committed by David Sterba
Browse files

Btrfs: set plug for fsync 



Setting plug can merge adjacent IOs before dispatching IOs to the disk
driver.

Without plug, it'd not be a problem for single disk usecases, but for
multiple disks using raid profile, a large IO can be split to several
IOs of stripe length, and plug can be helpful to bring them together
for each disk so that we can save several disk access.

Moreover, fsync issues synchronous writes, so plug can really take
effect.

Signed-off-by: default avatarLiu Bo <bo.li.liu@oracle.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 0fb08bcc

fs/btrfs/file.c

+9 −0
Original line number Diff line number Diff line
@@ -2019,10 +2019,19 @@ int btrfs_release_file(struct inode *inode, struct file *filp) 
static int start_ordered_ops(struct inode *inode, loff_t start, loff_t end)

{

	int ret;

	struct blk_plug plug;



	/*

	 * This is only called in fsync, which would do synchronous writes, so

	 * a plug can merge adjacent IOs as much as possible.  Esp. in case of

	 * multiple disks using raid profile, a large IO can be split to

	 * several segments of stripe length (currently 64K).

	 */

	blk_start_plug(&plug);

	atomic_inc(&BTRFS_I(inode)->sync_writers);

	ret = btrfs_fdatawrite_range(inode, start, end);

	atomic_dec(&BTRFS_I(inode)->sync_writers);

	blk_finish_plug(&plug);



	return ret;

}