Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3431a150 authored by Stefan Agner's avatar Stefan Agner Committed by Greg Kroah-Hartman
Browse files

usb: xhci: tegra: fix runtime PM error handling 



The address-of operator will always evaluate to true. However,
power should be explicitly disabled if no power domain is used.

Remove the address-of operator.

Fixes: 58c38116 ("usb: xhci: tegra: Add support for managing powergates")
Signed-off-by: default avatarStefan Agner <stefan@agner.ch>
Acked-by: default avatarJon Hunter <jonathanh@nvidia.com>
Signed-off-by: default avatarMathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 36eb9350

drivers/usb/host/xhci-tegra.c

+2 −2
Original line number Diff line number Diff line
@@ -1223,10 +1223,10 @@ static int tegra_xusb_probe(struct platform_device *pdev) 
	pm_runtime_disable(&pdev->dev);

	usb_put_hcd(tegra->hcd);

disable_xusbc:

	if (!&pdev->dev.pm_domain)

	if (!pdev->dev.pm_domain)

		tegra_powergate_power_off(TEGRA_POWERGATE_XUSBC);

disable_xusba:

	if (!&pdev->dev.pm_domain)

	if (!pdev->dev.pm_domain)

		tegra_powergate_power_off(TEGRA_POWERGATE_XUSBA);

put_padctl:

	tegra_xusb_padctl_put(tegra->padctl);