Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 341eff2b authored by Hemant Kumar's avatar Hemant Kumar
Browse files

mhi: core: Treat MHI_ASSERT as fatal error 



Currently MHI_ASSERT causes kernel panic in debug mode.
In performance mode it just prints warning and continues.
This can cause memory over-read, out of bound memory read.
All the places driver is asserting need to result into a
kernel panic to root cause the issue and prevent unwanted
memory access.

Change-Id: Ica8e1fec7be916621398cd4c5f8bfa6718c33d72
Signed-off-by: default avatarHemant Kumar <hemantk@codeaurora.org>
parent 80557daa

drivers/bus/mhi/core/mhi_internal.h

+1 −14
Original line number Diff line number Diff line 
/* SPDX-License-Identifier: GPL-2.0-only */

/* Copyright (c) 2018-2019, The Linux Foundation. All rights reserved. */

/* Copyright (c) 2018-2020, The Linux Foundation. All rights reserved. */



#ifndef _MHI_INT_H

#define _MHI_INT_H
@@ -946,22 +946,9 @@ irqreturn_t mhi_intvec_threaded_handlr(int irq_number, void *dev); 
irqreturn_t mhi_intvec_handlr(int irq_number, void *dev);

void mhi_ev_task(unsigned long data);



#ifdef CONFIG_MHI_DEBUG



#define MHI_ASSERT(cond, fmt, ...) do { \

	if (cond) \

		panic(fmt); \

} while (0)



#else



#define MHI_ASSERT(cond, fmt, ...) do { \

	if (cond) { \

		MHI_ERR(fmt); \

		WARN_ON(cond); \

	} \

} while (0)



#endif



#endif /* _MHI_INT_H */