Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 33fd472e authored by Mark Einon's avatar Mark Einon Committed by Greg Kroah-Hartman
Browse files

staging: et131x: Fix et131x smatch issues 



This fixes the following issues:

et131x_initpci.c +488 et131x_adjust_link(45) error: we previously assumed 'phydev' could be null.
et131x_initpci.c +504 et131x_adjust_link(61) warn: variable dereferenced before check 'phydev'

Signed-off-by: default avatarMark Einon <mark.einon@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 6617c369

drivers/staging/et131x/et131x_initpci.c

+2 −2
Original line number Diff line number Diff line
@@ -485,7 +485,7 @@ static void et131x_adjust_link(struct net_device *netdev) 
		et1310_config_mac_regs2(adapter);

	}



	if (phydev->link != adapter->link) {

	if (phydev && phydev->link != adapter->link) {

		/*

		 * Check to see if we are in coma mode and if

		 * so, disable it because we will not be able
@@ -501,7 +501,7 @@ static void et131x_adjust_link(struct net_device *netdev) 
			    "Link down - cable problem ?\n");

			adapter->boot_coma = 0;



			if (phydev && phydev->speed == SPEED_10) {

			if (phydev->speed == SPEED_10) {

				/* NOTE - Is there a way to query this without

				 * TruePHY?

				 * && TRU_QueryCoreType(adapter->hTruePhy, 0) ==