Commit 33acc40d authored Nov 27, 2017 by Geert Uytterhoeven Committed by Rob Herring Dec 06, 2017

of: unittest: Remove bogus overlay mutex release from overlay_data_add()



overlay_data_add() never takes the special overlay mutex, so it must not
be released in the error patch.

Presumably the call to of_overlay_mutex_unlock() is a relic from v1 of
the patch.

Fixes: f948d6d8 ("of: overlay: avoid race condition between applying multiple overlays")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Frank Rowand <frank.rowand@sony.com>
Signed-off-by: Rob Herring <robh@kernel.org>

parent 4fbd8d19

drivers/of/unittest.c

+0 −1

Original line number	Original line	Diff line number	Diff line
	@@ -2165,7 +2165,6 @@ static int __init overlay_data_add(int onum)
	ret = of_overlay_apply(info->np_overlay, &info->overlay_id);		ret = of_overlay_apply(info->np_overlay, &info->overlay_id);
	if (ret < 0) {		if (ret < 0) {
	pr_err("of_overlay_apply() (ret=%d), %d\n", ret, onum);		pr_err("of_overlay_apply() (ret=%d), %d\n", ret, onum);
	of_overlay_mutex_unlock();
	goto out_free_np_overlay;		goto out_free_np_overlay;
	}		}