Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 337d7c8a authored by Wolfram Sang's avatar Wolfram Sang Committed by Ulf Hansson
Browse files

mmc: mxcmmc: catch all errors when getting regulators 



Bail out everytime when mmc_regulator_get_supply() returns an errno, not
only when probing gets deferred. This is currently a no-op, because this
function only returns -EPROBE_DEFER or 0 right now. But if it will throw
another error somewhen, it will be for a reason. (This still doesn't change
that getting regulators is optional, so 0 can still mean no regulators
found). So, let us a) be future proof and b) have driver code which is
easier to understand.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
parent 2f98ef63

drivers/mmc/host/mxcmmc.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -1075,7 +1075,7 @@ static int mxcmci_probe(struct platform_device *pdev) 
		dat3_card_detect = true;

		dat3_card_detect = true;





	ret = mmc_regulator_get_supply(mmc);

	ret = mmc_regulator_get_supply(mmc);

	if (ret == -EPROBE_DEFER)

	if (ret)

		goto out_free;

		goto out_free;





	if (!mmc->ocr_avail) {

	if (!mmc->ocr_avail) {