Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3262ad82 authored by Jim Baxter's avatar Jim Baxter Committed by Felipe Balbi
Browse files

usb: gadget: f_fs: Stop ffs_closed NULL pointer dereference 



The struct ffs_data::private_data has a pointer to
ffs_dev stored in it during the ffs_fs_mount() function
however it is not cleared when the ffs_dev is freed
later which causes the ffs_closed function to crash
with "Unable to handle kernel NULL pointer dereference"
error when using the data in ffs_data::private_data.

This clears this pointer during the ffs_free_dev clean
up function.

Signed-off-by: default avatarJim Baxter <jim_baxter@mentor.com>
Signed-off-by: default avatarJiada Wang <jiada_wang@mentor.com>
Signed-off-by: default avatarHarish Jenny K N <harish_kandiga@mentor.com>
Signed-off-by: default avatarFelipe Balbi <felipe.balbi@linux.intel.com>
parent 9d6173e1

drivers/usb/gadget/function/f_fs.c

+5 −0
Original line number Diff line number Diff line
@@ -3502,6 +3502,11 @@ static void _ffs_free_dev(struct ffs_dev *dev) 
	list_del(&dev->entry);

	if (dev->name_allocated)

		kfree(dev->name);



	/* Clear the private_data pointer to stop incorrect dev access */

	if (dev->ffs_data)

		dev->ffs_data->private_data = NULL;



	kfree(dev);

	if (list_empty(&ffs_devices))

		functionfs_cleanup();