Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 32471bda authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Mauro Carvalho Chehab
Browse files

media: staging: atomisp: Remove ->gpio_ctrl() callback 



There is redundant callback which does nothing in upstreamed version of
the driver.

Remove it along with user call places.

Mostly done with help of coccinelle.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@s-opensource.com>
parent d2cde883

drivers/staging/media/atomisp/i2c/atomisp-gc0310.c

+0 −4
Original line number Diff line number Diff line
@@ -771,10 +771,6 @@ static int gpio_ctrl(struct v4l2_subdev *sd, bool flag) 
	if (!dev || !dev->platform_data)

		return -ENODEV;



	/* Non-gmin platforms use the legacy callback */

	if (dev->platform_data->gpio_ctrl)

		return dev->platform_data->gpio_ctrl(sd, flag);



	/* GPIO0 == "reset" (active low), GPIO1 == "power down" */

	if (flag) {

		/* Pulse reset, then release power down */

drivers/staging/media/atomisp/i2c/atomisp-gc2235.c

+0 −4
Original line number Diff line number Diff line
@@ -571,10 +571,6 @@ static int gpio_ctrl(struct v4l2_subdev *sd, bool flag) 
	if (!dev || !dev->platform_data)

		return -ENODEV;



	/* Non-gmin platforms use the legacy callback */

	if (dev->platform_data->gpio_ctrl)

		return dev->platform_data->gpio_ctrl(sd, flag);



	ret |= dev->platform_data->gpio1_ctrl(sd, !flag);

	usleep_range(60, 90);

	return dev->platform_data->gpio0_ctrl(sd, flag);

drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c

+0 −4
Original line number Diff line number Diff line
@@ -480,10 +480,6 @@ static int gpio_ctrl(struct v4l2_subdev *sd, bool flag) 
	if (!dev || !dev->platform_data)

		return -ENODEV;



	/* Non-gmin platforms use the legacy callback */

	if (dev->platform_data->gpio_ctrl)

		return dev->platform_data->gpio_ctrl(sd, flag);



	/* Note: current modules wire only one GPIO signal (RESET#),

	 * but the schematic wires up two to the connector.  BIOS

	 * versions have been unfortunately inconsistent with which

drivers/staging/media/atomisp/i2c/atomisp-ov2680.c

+0 −4
Original line number Diff line number Diff line
@@ -871,10 +871,6 @@ static int gpio_ctrl(struct v4l2_subdev *sd, bool flag) 
	if (!dev || !dev->platform_data)

		return -ENODEV;



	/* Non-gmin platforms use the legacy callback */

	if (dev->platform_data->gpio_ctrl)

		return dev->platform_data->gpio_ctrl(sd, flag);



	/* The OV2680 documents only one GPIO input (#XSHUTDN), but

	 * existing integrations often wire two (reset/power_down)

	 * because that is the way other sensors work.  There is no

drivers/staging/media/atomisp/i2c/atomisp-ov2722.c

+0 −4
Original line number Diff line number Diff line
@@ -677,10 +677,6 @@ static int gpio_ctrl(struct v4l2_subdev *sd, bool flag) 
	if (!dev || !dev->platform_data)

		return -ENODEV;



	/* Non-gmin platforms use the legacy callback */

	if (dev->platform_data->gpio_ctrl)

		return dev->platform_data->gpio_ctrl(sd, flag);



	/* Note: the GPIO order is asymmetric: always RESET#

	 * before PWDN# when turning it on or off.

	 */