hvc_console: Fix race between hvc_close and hvc_remove
I don't claim to understand the tty layer, but it seems like hvc_open and
hvc_close should be balanced in their kref reference counting.
Right now we get a kref every call to hvc_open:
        if (hp->count++ > 0) {
                tty_kref_get(tty); <----- here
                spin_unlock_irqrestore(&hp->lock, flags);
                hvc_kick();
                return 0;
        } /* else count == 0 */
        tty->driver_data = hp;
        hp->tty = tty_kref_get(tty); <------ or here if hp->count was 0
But hvc_close has:
        tty_kref_get(tty);
        if (--hp->count == 0) {
...
                /* Put the ref obtained in hvc_open() */
                tty_kref_put(tty);
...
        }
        tty_kref_put(tty);
Since the outside kref get/put balance we only do a single kref_put when
count reaches 0.
The patch below changes things to call tty_kref_put once for every
hvc_close call, and with that my machine boots fine.
Signed-off-by: 
Anton Blanchard <anton@samba.org>
Acked-by: 
Amit Shah <amit.shah@redhat.com>
Signed-off-by: 
Rusty Russell <rusty@rustcorp.com.au>
Loading
Please register or sign in to comment