Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 315e770e authored by Takashi Iwai's avatar Takashi Iwai Committed by Greg Kroah-Hartman
Browse files

ALSA: usb-audio: Fix NULL dererence at error path 



commit 568be8aaf8a535f79c4db76cabe17b035aa2584d upstream.

At an error path to release URB buffers and contexts, the driver might
hit a NULL dererence for u->urb pointer, when u->buffer_size has been
already set but the actual URB allocation failed.

Fix it by adding the NULL check of urb.  Also, make sure that
buffer_size is cleared after the error path or the close.

Cc: <stable@vger.kernel.org>
Reported-by: default avatarSabri N. Ferreiro <snferreiro1@gmail.com>
Link: https://lore.kernel.org/r/CAKG+3NRjTey+fFfUEGwuxL-pi_=T4cUskYG9OzpzHytF+tzYng@mail.gmail.com
Link: https://lore.kernel.org/r/20220930100129.19445-1-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 46f0aed4

sound/usb/endpoint.c

+2 −1
Original line number Diff line number Diff line
@@ -86,12 +86,13 @@ static inline unsigned get_usb_high_speed_rate(unsigned int rate) 
 */

static void release_urb_ctx(struct snd_urb_ctx *u)

{

	if (u->buffer_size)

	if (u->urb && u->buffer_size)

		usb_free_coherent(u->ep->chip->dev, u->buffer_size,

				  u->urb->transfer_buffer,

				  u->urb->transfer_dma);

	usb_free_urb(u->urb);

	u->urb = NULL;

	u->buffer_size = 0;

}



static const char *usb_error_string(int err)