Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 31571757 authored by Greg Rose's avatar Greg Rose Committed by Jeff Kirsher
Browse files

ixgbevf: Remove mailbox spinlock from the reset function 



The spinlocks are not required during reset.  There won't be any
contention for the mailbox resource.

Signed-off-by: default avatarGreg Rose <gregory.v.rose@intel.com>
Tested-by: default avatarSibai Li <sibai.li@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
parent 92fe0bf7

drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c

+0 −4
Original line number Original line Diff line number Diff line
@@ -1702,15 +1702,11 @@ void ixgbevf_reset(struct ixgbevf_adapter *adapter) 
	struct ixgbe_hw *hw = &adapter->hw;

	struct ixgbe_hw *hw = &adapter->hw;

	struct net_device *netdev = adapter->netdev;

	struct net_device *netdev = adapter->netdev;





	spin_lock_bh(&adapter->mbx_lock);



	if (hw->mac.ops.reset_hw(hw))

	if (hw->mac.ops.reset_hw(hw))

		hw_dbg(hw, "PF still resetting\n");

		hw_dbg(hw, "PF still resetting\n");

	else

	else

		hw->mac.ops.init_hw(hw);

		hw->mac.ops.init_hw(hw);





	spin_unlock_bh(&adapter->mbx_lock);



	if (is_valid_ether_addr(adapter->hw.mac.addr)) {

	if (is_valid_ether_addr(adapter->hw.mac.addr)) {

		memcpy(netdev->dev_addr, adapter->hw.mac.addr,

		memcpy(netdev->dev_addr, adapter->hw.mac.addr,

		       netdev->addr_len);

		       netdev->addr_len);