Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 313eae63 authored by Julian Anastasov's avatar Julian Anastasov Committed by Pablo Neira Ayuso
Browse files

ipvs: prefer NETDEV_DOWN event to free cached dsts 



The real server becomes unreachable on down event,
no need to wait device unregistration. Should help in
releasing dsts early before dst->dev is replaced with lo.

Signed-off-by: default avatarJulian Anastasov <ja@ssi.bg>
Signed-off by: Hans Schillstrom <hans@schillstrom.com>
Signed-off-by: default avatarSimon Horman <horms@verge.net.au>
parent c90558da

net/netfilter/ipvs/ip_vs_ctl.c

+3 −5
Original line number Diff line number Diff line
@@ -1514,10 +1514,8 @@ __ip_vs_dev_reset(struct ip_vs_dest *dest, struct net_device *dev) 
	spin_unlock_bh(&dest->dst_lock);



}

/*

 * Netdev event receiver

 * Currently only NETDEV_UNREGISTER is handled, i.e. if we hold a reference to

 * a device that is "unregister" it must be released.

/* Netdev event receiver

 * Currently only NETDEV_DOWN is handled to release refs to cached dsts

 */

static int ip_vs_dst_event(struct notifier_block *this, unsigned long event,

			    void *ptr)
@@ -1529,7 +1527,7 @@ static int ip_vs_dst_event(struct notifier_block *this, unsigned long event, 
	struct ip_vs_dest *dest;

	unsigned int idx;



	if (event != NETDEV_UNREGISTER || !ipvs)

	if (event != NETDEV_DOWN || !ipvs)

		return NOTIFY_DONE;

	IP_VS_DBG(3, "%s() dev=%s\n", __func__, dev->name);

	EnterFunction(2);