Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 30d758ce authored Dec 07, 2016 by Oleg Drokin Committed by Greg Kroah-Hartman Jan 03, 2017

staging/lustre: Declare lu_context/session_tags_default



Make the declaration in a header, not as an extern in a C file,
that is frowned upon.
This also makes sparse a little bit more happy.

Signed-off-by: Oleg Drokin <green@linuxhacker.ru>
Reviewed-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent f62427b8

drivers/staging/lustre/lustre/include/lu_object.h

+3 −0

Original line number	Original line	Diff line number	Diff line
	@@ -1326,5 +1326,8 @@ void lu_buf_realloc(struct lu_buf *buf, size_t size);
	int lu_buf_check_and_grow(struct lu_buf *buf, size_t len);		int lu_buf_check_and_grow(struct lu_buf *buf, size_t len);
	struct lu_buf lu_buf_check_and_alloc(struct lu_buf buf, size_t len);		struct lu_buf lu_buf_check_and_alloc(struct lu_buf buf, size_t len);

			extern __u32 lu_context_tags_default;
			extern __u32 lu_session_tags_default;

	/** @} lu */		/** @} lu */
	#endif /* __LUSTRE_LU_OBJECT_H */		#endif /* __LUSTRE_LU_OBJECT_H */

drivers/staging/lustre/lustre/obdclass/cl_object.c

+1 −2

Original line number	Original line	Diff line number	Diff line
	@@ -54,6 +54,7 @@
	#include <linux/list.h>		#include <linux/list.h>
	#include "../../include/linux/libcfs/libcfs_hash.h" /* for cfs_hash stuff */		#include "../../include/linux/libcfs/libcfs_hash.h" /* for cfs_hash stuff */
	#include "../include/cl_object.h"		#include "../include/cl_object.h"
			#include "../include/lu_object.h"
	#include "cl_internal.h"		#include "cl_internal.h"

	static struct kmem_cache *cl_env_kmem;		static struct kmem_cache *cl_env_kmem;
	@@ -61,8 +62,6 @@ static struct kmem_cache *cl_env_kmem;
	/** Lock class of cl_object_header::coh_attr_guard */		/** Lock class of cl_object_header::coh_attr_guard */
	static struct lock_class_key cl_attr_guard_class;		static struct lock_class_key cl_attr_guard_class;

	extern __u32 lu_context_tags_default;
	extern __u32 lu_session_tags_default;
	/**		/**
	* Initialize cl_object_header.		* Initialize cl_object_header.
	*/		*/