Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 30c96ce5 authored by Jani Nikula's avatar Jani Nikula Committed by Jiri Kosina
Browse files

powerpc/BSR: fix device_create() return value check 



Use IS_ERR() instead of comparing to NULL.

Signed-off-by: default avatarJani Nikula <ext-jani.1.nikula@nokia.com>
Acked-by: default avatarSonny Rao <sonnyrao@us.ibm.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 3e21ec22

drivers/char/bsr.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -252,7 +252,7 @@ static int bsr_add_node(struct device_node *bn) 




		cur->bsr_device = device_create(bsr_class, NULL, cur->bsr_dev,

		cur->bsr_device = device_create(bsr_class, NULL, cur->bsr_dev,

						cur, cur->bsr_name);

						cur, cur->bsr_name);

		if (!cur->bsr_device) {

		if (IS_ERR(cur->bsr_device)) {

			printk(KERN_ERR "device_create failed for %s\n",

			printk(KERN_ERR "device_create failed for %s\n",

			       cur->bsr_name);

			       cur->bsr_name);

			cdev_del(&cur->bsr_cdev);

			cdev_del(&cur->bsr_cdev);