Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 307ab2a9 authored by Mario Limonciello's avatar Mario Limonciello Committed by Darren Hart (VMware)
Browse files

platform/x86: dell-smbios-wmi: release mutex lock on WMI call failure 



Unbound devices may race with calling this function causing the mutex
to stay locked.  This failure mode should have released the mutex too.

Signed-off-by: default avatarMario Limonciello <mario.limonciello@dell.com>
Signed-off-by: default avatarDarren Hart (VMware) <dvhart@infradead.org>
parent 5e3e2297

drivers/platform/x86/dell-smbios-wmi.c

+5 −2
Original line number Diff line number Diff line
@@ -91,8 +91,10 @@ int dell_smbios_wmi_call(struct calling_interface_buffer *buffer) 


	mutex_lock(&call_mutex);

	priv = get_first_smbios_priv();

	if (!priv)

		return -ENODEV;

	if (!priv) {

		ret = -ENODEV;

		goto out_wmi_call;

	}



	size = sizeof(struct calling_interface_buffer);

	difference = priv->req_buf_size - sizeof(u64) - size;
@@ -101,6 +103,7 @@ int dell_smbios_wmi_call(struct calling_interface_buffer *buffer) 
	memcpy(&priv->buf->std, buffer, size);

	ret = run_smbios_call(priv->wdev);

	memcpy(buffer, &priv->buf->std, size);

out_wmi_call:

	mutex_unlock(&call_mutex);



	return ret;