Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3011684c authored by Dan Carpenter's avatar Dan Carpenter Committed by Nicholas Bellinger
Browse files

target: handle empty string writes in sysfs 



These are root only and we're not likely to hit the problem in practise,
but it makes the static checkers happy.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent c3bc93da

drivers/target/target_core_configfs.c

+8 −4
Original line number Diff line number Diff line
@@ -1704,13 +1704,15 @@ static ssize_t target_core_store_dev_alias( 
		return -EINVAL;

	}



	se_dev->su_dev_flags |= SDF_USING_ALIAS;

	read_bytes = snprintf(&se_dev->se_dev_alias[0], SE_DEV_ALIAS_LEN,

			"%s", page);



	if (!read_bytes)

		return -EINVAL;

	if (se_dev->se_dev_alias[read_bytes - 1] == '\n')

		se_dev->se_dev_alias[read_bytes - 1] = '\0';



	se_dev->su_dev_flags |= SDF_USING_ALIAS;



	pr_debug("Target_Core_ConfigFS: %s/%s set alias: %s\n",

		config_item_name(&hba->hba_group.cg_item),

		config_item_name(&se_dev->se_dev_group.cg_item),
@@ -1753,13 +1755,15 @@ static ssize_t target_core_store_dev_udev_path( 
		return -EINVAL;

	}



	se_dev->su_dev_flags |= SDF_USING_UDEV_PATH;

	read_bytes = snprintf(&se_dev->se_dev_udev_path[0], SE_UDEV_PATH_LEN,

			"%s", page);



	if (!read_bytes)

		return -EINVAL;

	if (se_dev->se_dev_udev_path[read_bytes - 1] == '\n')

		se_dev->se_dev_udev_path[read_bytes - 1] = '\0';



	se_dev->su_dev_flags |= SDF_USING_UDEV_PATH;



	pr_debug("Target_Core_ConfigFS: %s/%s set udev_path: %s\n",

		config_item_name(&hba->hba_group.cg_item),

		config_item_name(&se_dev->se_dev_group.cg_item),