Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2f02bc8a authored Nov 07, 2012 by Alan Stern Committed by Greg Kroah-Hartman Nov 11, 2012

USB: report submission of active URBs



This patch (as1633) changes slightly the way usbcore handled
submissions of URBs that are already active.  It will now return
-EBUSY rather than -EINVAL, and it will call WARN_ONCE to draw
people's attention to the bug.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 2656a9ab

Documentation/usb/error-codes.txt

+2 −0

Original line number	Diff line number	Diff line
		@@ -21,6 +21,8 @@ Non-USB-specific:

		USB-specific:

		-EBUSY The URB is already active.

		-ENODEV specified USB-device or bus doesn't exist

		-ENOENT specified interface or endpoint does not exist or

drivers/usb/core/urb.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -321,8 +321,13 @@ int usb_submit_urb(struct urb *urb, gfp_t mem_flags)
		struct usb_host_endpoint *ep;
		int is_out;

		if (!urb \|\| urb->hcpriv \|\| !urb->complete)
		if (!urb \|\| !urb->complete)
		return -EINVAL;
		if (urb->hcpriv) {
		WARN_ONCE(1, "URB %p submitted while active\n", urb);
		return -EBUSY;
		}

		dev = urb->dev;
		if ((!dev) \|\| (dev->state < USB_STATE_UNAUTHENTICATED))
		return -ENODEV;