Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2ece068e authored by Muhammad Falak R Wani's avatar Muhammad Falak R Wani Committed by David S. Miller
Browse files

ptp: use memdup_user(). 



Use memdup_user to duplicate a memory region from user-space to
kernel-space, instead of open coding using kmalloc & copy_from_user.

Signed-off-by: default avatarMuhammad Falak R Wani <falakreyaz@gmail.com>
Acked-by: default avatarRichard Cochran <richardcochran@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 8da07a39

drivers/ptp/ptp_chardev.c

+3 −8
Original line number Diff line number Diff line
@@ -208,14 +208,9 @@ long ptp_ioctl(struct posix_clock *pc, unsigned int cmd, unsigned long arg) 
		break;



	case PTP_SYS_OFFSET:

		sysoff = kmalloc(sizeof(*sysoff), GFP_KERNEL);

		if (!sysoff) {

			err = -ENOMEM;

			break;

		}

		if (copy_from_user(sysoff, (void __user *)arg,

				   sizeof(*sysoff))) {

			err = -EFAULT;

		sysoff = memdup_user((void __user *)arg, sizeof(*sysoff));

		if (IS_ERR(sysoff)) {

			err = PTR_ERR(sysoff);

			break;

		}

		if (sysoff->n_samples > PTP_MAX_SAMPLES) {