Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2dc916f4 authored by Ajay Singh's avatar Ajay Singh Committed by Greg Kroah-Hartman
Browse files

staging: wilc1000: fix to free allocated memory in wilc_add_ptk() 



Free allocated memory in wilc_add_ptk() when it fails to enqueue the
command.

Signed-off-by: default avatarAjay Singh <ajay.kathat@microchip.com>
Reviewed-by: default avatarClaudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8d5b5e6a

drivers/staging/wilc1000/host_interface.c

+7 −6
Original line number Diff line number Diff line
@@ -2793,7 +2793,7 @@ int wilc_add_ptk(struct wilc_vif *vif, const u8 *ptk, u8 ptk_key_len, 
		 const u8 *mac_addr, const u8 *rx_mic, const u8 *tx_mic,

		 u8 mode, u8 cipher_mode, u8 index)

{

	int result = 0;

	int result;

	struct host_if_msg msg;

	struct host_if_drv *hif_drv = vif->hif_drv;

	u8 key_len = ptk_key_len;
@@ -2838,15 +2838,16 @@ int wilc_add_ptk(struct wilc_vif *vif, const u8 *ptk, u8 ptk_key_len, 
	msg.vif = vif;



	result = wilc_enqueue_cmd(&msg);



	if (result)

	if (result) {

		netdev_err(vif->ndev, "PTK Key\n");

	else

		wait_for_completion(&hif_drv->comp_test_key_block);



		kfree(msg.body.key_info.attr.wpa.key);

		return result;

	}



	wait_for_completion(&hif_drv->comp_test_key_block);

	return 0;

}



int wilc_add_rx_gtk(struct wilc_vif *vif, const u8 *rx_gtk, u8 gtk_key_len,

		    u8 index, u32 key_rsc_len, const u8 *key_rsc,

		    const u8 *rx_mic, const u8 *tx_mic, u8 mode,