Commit 2d79ab16 authored Nov 07, 2013 by Ezequiel Garcia Committed by Brian Norris Jan 03, 2014

mtd: nand: pxa3xx: Use chip->cmdfunc instead of the internal



Whenever possible, it's always better to use the generic chip->cmdfunc
instead of the internal pxa3xx_nand_cmdfunc().
In this particular case, this will allow to have multiple cmdfunc()
implementations for different SoC variants.

Reviewed-by: Huang Shijie <shijie8@gmail.com>
Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Tested-by: Daniel Mack <zonque@gmail.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>

parent c7e9c7e7

drivers/mtd/nand/pxa3xx_nand.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -1011,14 +1011,18 @@ static void pxa3xx_nand_free_buff(struct pxa3xx_nand_info *info)
		static int pxa3xx_nand_sensing(struct pxa3xx_nand_info *info)
		{
		struct mtd_info *mtd;
		struct nand_chip *chip;
		int ret;

		mtd = info->host[info->cs]->mtd;
		chip = mtd->priv;

		/* use the common timing to make a try */
		ret = pxa3xx_nand_config_flash(info, &builtin_flash_types[0]);
		if (ret)
		return ret;

		pxa3xx_nand_cmdfunc(mtd, NAND_CMD_RESET, 0, 0);
		chip->cmdfunc(mtd, NAND_CMD_RESET, 0, 0);
		if (info->is_ready)
		return 0;