Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2d4b8420 authored by Clemens Ladisch's avatar Clemens Ladisch Committed by Takashi Iwai
Browse files

sound: rawmidi: disable active-sensing-on-close by default 



Sending an Active Sensing message when closing a port can interfere with
the following data if the port is reopened and a note-on is sent before
the device's timeout has elapsed.  Therefore, it is better to disable
this setting by default.

Signed-off-by: default avatarClemens Ladisch <clemens@ladisch.de>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 08d03340

sound/core/rawmidi.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -274,7 +274,7 @@ static int open_substream(struct snd_rawmidi *rmidi, 
		return err;

		return err;

	substream->opened = 1;

	substream->opened = 1;

	if (substream->use_count++ == 0)

	if (substream->use_count++ == 0)

		substream->active_sensing = 1;

		substream->active_sensing = 0;

	if (mode & SNDRV_RAWMIDI_LFLG_APPEND)

	if (mode & SNDRV_RAWMIDI_LFLG_APPEND)

		substream->append = 1;

		substream->append = 1;

	rmidi->streams[substream->stream].substream_opened++;

	rmidi->streams[substream->stream].substream_opened++;

sound/core/seq/seq_midi.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -237,6 +237,7 @@ static int midisynth_use(void *private_data, struct snd_seq_port_subscribe *info 
	memset(&params, 0, sizeof(params));

	memset(&params, 0, sizeof(params));

	params.avail_min = 1;

	params.avail_min = 1;

	params.buffer_size = output_buffer_size;

	params.buffer_size = output_buffer_size;

	params.no_active_sensing = 1;

	if ((err = snd_rawmidi_output_params(msynth->output_rfile.output, &params)) < 0) {

	if ((err = snd_rawmidi_output_params(msynth->output_rfile.output, &params)) < 0) {

		snd_rawmidi_kernel_release(&msynth->output_rfile);

		snd_rawmidi_kernel_release(&msynth->output_rfile);

		return err;

		return err;